Call virtualenv by module #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
call-virtualenv-by-module
branch
from
202182a
to
4fee8ec
Compare
uranusjr
force-pushed
the
call-virtualenv-by-module
branch
from
4fee8ec
to
55d77b2
Compare
techalchemy
reviewed
May 15, 2018
| @@ -887,7 +887,7 @@ def do_create_virtualenv(python=None, site_packages=False): | |||
| # The user wants the virtualenv in the project. | |||
| if project.is_venv_in_project(): | |||
| cmd = [ | |||
| 'virtualenv', | |||
| sys.executable, '-m', 'virtualenv', | |||
There was a problem hiding this comment.
We probably want to use which('virtualenv') and fallback to sys.executable in case we can't find virtualenv or something, no?
There was a problem hiding this comment.
I wonder what the merit is. Is it so the user can set virtualenv to, like, a “better virtualenv”? Using our own dependency (even if not vendored) feels a much safer, predictable solution to me. Also in practice virtualenv hasn’t been updated in almost two years (last in November 2016), so the extra which check is more than likely just wasted.
There was a problem hiding this comment.
yeah i thought about it more and this does guarantee that we get the one that got installed with pipenv, so I like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is actually a regression?