Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade vendored resolvelib to 0.6.0 #9771

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Upgrade vendored resolvelib to 0.6.0 #9771

merged 3 commits into from
Apr 12, 2021

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Apr 3, 2021 •
edited
Loading

First step toward #8785.

@uranusjr uranusjr force-pushed the resolvelib-060 branch 2 times, most recently from d1543e8 to 10488be Compare April 3, 2021 22:24
pradyunsg
pradyunsg approved these changes Apr 3, 2021
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once you rebase.

@uranusjr uranusjr added this to the Drop the legacy resolver milestone Apr 3, 2021
@uranusjr uranusjr marked this pull request as ready for review April 3, 2021 22:31
@uranusjr uranusjr closed this Apr 4, 2021
@uranusjr uranusjr reopened this Apr 4, 2021
@uranusjr
Copy link
Member Author

uranusjr commented Apr 4, 2021

I think the 0.6.0 implementation has bugs that cause the resolver to run in circles. Don’t merge this yet.

@uranusjr uranusjr marked this pull request as draft April 4, 2021 11:04
@sbidoul
Copy link
Member

sbidoul commented Apr 4, 2021

I cancelled the CI workflow to free it up for other PRs.

@uranusjr uranusjr force-pushed the resolvelib-060 branch 2 times, most recently from 8b3ef88 to 60bbcfb Compare April 4, 2021 12:34
@uranusjr uranusjr marked this pull request as ready for review April 4, 2021 13:21
@uranusjr uranusjr requested a review from pradyunsg April 4, 2021 13:32
@uranusjr uranusjr mentioned this pull request Apr 4, 2021
Merged
@uranusjr
Copy link
Member Author

uranusjr commented Apr 4, 2021

I think this is working now.

@uranusjr
Copy link
Member Author

uranusjr commented Apr 5, 2021

Tentitively adding this for 21.1. Feel free to remove it if this proves problematic.

@uranusjr uranusjr closed this Apr 12, 2021
@uranusjr uranusjr reopened this Apr 12, 2021
@uranusjr uranusjr merged commit e6a65fc into pypa:main Apr 12, 2021
@uranusjr uranusjr deleted the resolvelib-060 branch April 12, 2021 19:33
@uranusjr uranusjr mentioned this pull request Apr 24, 2021
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21.1
Development

Successfully merging this pull request may close these issues.
3 participants
@uranusjr @sbidoul @pradyunsg