Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Describe --upgrade-strategy and direct requirements explicitly #8739

Closed
wants to merge 2 commits into from

Conversation

EricCousineau-TRI
Copy link
Contributor

Add a brief example

Resolves #8726

@EricCousineau-TRI
Copy link
Contributor Author

@uranusjr Here's a low-effort attempt to render our convo as a PR. I settled on "direct/indirect requirements", with some inline explanation, as those seemed like existing terms of art.
WDYT?


This will only update ``SomePackage`` as it is a direct requirement. Any
of its dependencies (indirect requirements) will be affected by the
``--upgrade-strategy`` command.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indirect requirements can still be upgraded here if a later version of SomePackage needs them upgraded. Say

  • SomePackage==1.0 needs DepPackage==1.0
  • SomePackage==2.0 needs DepPackage==2.0

With SomePackage==1.0 and DepPackage==1.0 initially installed, pip install --upgrade SomePackage will still upgrade DepPackage.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IOW, only SomePackage is guarenteed to be upgraded. Its dependencies are upgraded only if needed.

@pradyunsg pradyunsg added the type: docs Documentation related label Aug 10, 2020
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 4, 2021
@pradyunsg
Copy link
Member

pradyunsg commented Mar 5, 2021

Closing as this is significantly out of date, and has merge conflicts. Please do feel free to resubmit an updated PR for this! ^>^

Thanks @EricCousineau-TRI for the PR! :)

@EricCousineau-TRI
Copy link
Contributor Author

Sorry! Saw something shiny a few months back 😬

Filed #9692 as redux.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs rebase or merge PR has conflicts with current master type: docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Description of "--upgrade-strategy=only-if-needed" seems inconsistent?
4 participants