Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use UTF-8 to read pyvenv.cfg #8718

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Always use UTF-8 to read pyvenv.cfg #8718

merged 1 commit into from
Aug 7, 2020

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Aug 6, 2020

Fix #8717.

@pradyunsg pradyunsg added this to the 20.2.2 milestone Aug 7, 2020
@pradyunsg pradyunsg merged commit e8f5219 into pypa:master Aug 7, 2020
@uranusjr uranusjr deleted the pyvenv-cfg-encoding branch August 7, 2020 10:23
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Aug 11, 2020
@pradyunsg
Merge pull request pypa#8718 from uranusjr/pyvenv-cfg-encoding
516c743 
Always use UTF-8 to read pyvenv.cfg
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbidoul sbidoul sbidoul approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.2.2
Development

Successfully merging this pull request may close these issues.

Pip 20.2.1 causes UnicodeDecodeError
3 participants
@uranusjr @sbidoul @pradyunsg