Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert defaulting to in-place builds for local directories #8221

Merged
merged 5 commits into from
May 14, 2020

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented May 12, 2020

Toward #7555
Reopens (😞) #7549, #6276, #3500, #2195

@pradyunsg
Copy link
Member Author

TODO: rebase on master, for fixing CI.

@sbidoul
Copy link
Member

sbidoul commented May 12, 2020

Technically, the revert seems ok. Thanks @pradyunsg!

Still wondering if a good communication campaign about the change would not be better than a revert. Difficult choice.

@pradyunsg
Copy link
Member Author

pradyunsg commented May 12, 2020

I thought most of us were in agreement about this, that our best course of action is revert and re-evaluate. Plus there's been a "big blob of text" (#8165 (comment)) communicating to users that -- "we'll be reverting the "build in place" behavior change in a pip 20.1.1 release".

I think the ship has sailed on "if" we revert this now -- we will -- but I don't think there's any reason we can't reintroduce this in pip 20.2 with a better (read: more thought out, less rushed because of @pradyunsg) rollout plan. :)

Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure how best to review something like this (I assume you used git revert, and I certainly haven't checked line for line that it correctly reverted the commits it should have done) but in general this LGTM.

@pradyunsg pradyunsg merged commit 1dbcd12 into pypa:master May 14, 2020
@pradyunsg pradyunsg deleted the revert-in-place-builds branch May 14, 2020 10:53
pradyunsg added a commit to pradyunsg/pip that referenced this pull request May 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants