Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect comment in tests in test_install #8012

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Fix incorrect comment in tests in test_install #8012

merged 1 commit into from
Apr 10, 2020

Conversation

deveshks
Copy link
Contributor

@deveshks deveshks commented Apr 10, 2020 •
edited
Loading

Addresses the additional review comments made in #7987 after it got merged. (#7987 (review))

Also fixes and closes #7731, closes #2926, closes #3710 and closes #7971
cc @xavfernandez , @sbidoul

@deveshks deveshks mentioned this pull request Apr 10, 2020
Merged
@sbidoul
Copy link
Member

sbidoul commented Apr 10, 2020

LGTM, while you are at it can you update the comments about PYTHONPATH in test_list_include_work_dir_pkg to match those used in other *work_dir* tests?

@deveshks deveshks force-pushed the fix-comments-in-test-install branch from 8c09f39 to 528a193 Compare April 10, 2020 13:32
@deveshks
Copy link
Contributor Author

Thanks @xavfernandez for the approval.

Hi @sbidoul , I have fixed the comment as you mentioned. Please take a look, and if it's okay, I can ask @pradyunsg to merge it 😊

@pradyunsg pradyunsg added the C: tests Testing and related things label Apr 10, 2020
@pradyunsg
Copy link
Member

Happy to merge once CI passes.

@deveshks
Copy link
Contributor Author

Happy to merge once CI passes.

Thanks @pradyunsg . I see that the CI has passed. Please do the needful 😊

@pradyunsg pradyunsg merged commit 5c9e83a into pypa:master Apr 10, 2020
@deveshks deveshks deleted the fix-comments-in-test-install branch April 19, 2020 04:38
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbidoul sbidoul sbidoul approved these changes

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: tests Testing and related things
Projects
None yet
Milestone
No milestone
4 participants
@deveshks @sbidoul @pradyunsg @xavfernandez