Move some initialization out of __init__ #7147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only relevant for our usage of --trusted-host, so it is enough to initialize it in network.session.
chrahunt
added
skip news
chrahunt
force-pushed
the
refactor/move-requests-init
branch
from
10d44a6
to
7a630fc
Compare
chrahunt
changed the title
pradyunsg
requested changes
Oct 8, 2019
chrahunt
force-pushed
the
refactor/move-requests-init
branch
from
7a630fc
to
02c92da
Compare
Saves >=10ms on irrelevant platforms.
chrahunt
force-pushed
the
refactor/move-requests-init
branch
from
02c92da
to
3eda51f
Compare
pradyunsg
approved these changes
Oct 8, 2019
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #7061.