Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove exhaustive file checks #7141

Closed
wants to merge 1 commit into from

Conversation

chrahunt
Copy link
Member

@chrahunt chrahunt commented Oct 5, 2019

Currently in scripttest all files contents in the script base directory before and after the script execution are iterated over and checksummed. This is a test to see what kind of gains we could get in test execution speed if we make these checks more specific.

@chrahunt chrahunt added type: maintenance Related to Development and Maintenance Processes skip news Does not need a NEWS file entry (eg: trivial changes) labels Oct 5, 2019
@chrahunt chrahunt force-pushed the refactor/explicit-file-checks branch from b7c4f78 to e8f0b3f Compare October 5, 2019 23:52
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Oct 7, 2019
@pradyunsg pradyunsg mentioned this pull request Nov 8, 2019
12 tasks
@chrahunt
Copy link
Member Author

chrahunt commented Nov 8, 2019

There doesn't seem to be an obvious improvement, so I'll close this for now. I added it to #4497, so we can try again later if we get down that far in the list.

@chrahunt chrahunt closed this Nov 8, 2019
@chrahunt chrahunt deleted the refactor/explicit-file-checks branch November 8, 2019 02:14
@chrahunt chrahunt restored the refactor/explicit-file-checks branch November 8, 2019 02:14
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation needs rebase or merge PR has conflicts with current master skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants