Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bypassed pip upgrade warning on Windows #6864

Merged
merged 5 commits into from
Aug 25, 2019
Merged

Fix bypassed pip upgrade warning on Windows #6864

merged 5 commits into from
Aug 25, 2019

Conversation

atugushev
Copy link
Contributor

Fixes #6841

@atugushev atugushev force-pushed the fix-issue-6841 branch 2 times, most recently from 3c7fb1f to dd58736 Compare August 12, 2019 18:34
@pradyunsg
Copy link
Member

Thanks for the PR! Much appreciated!

Can you confirm that this handles the case of invoking pip via pip3 or pip3.7?

If not, let's handle that case as well here.

@atugushev
Copy link
Contributor Author

atugushev commented Aug 12, 2019 •
edited
Loading

@pradyunsg

Thanks for catching! I've fixed it and made the first test parametrized.

chrahunt
chrahunt reviewed Aug 13, 2019
View reviewed changes
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this!

One note, the error message from your Appveyor example here may be a little confusing to someone installing a package.

ERROR: To modify pip, please run the following command:
C:\Python36\python.exe -m pip install --upgrade briefcase

Would it be straightforward (and worthwhile) to special-case this to indicate that pip is being modified because it is listed as a dependency (and maybe what it is listed as a dependency of)?

@atugushev
Copy link
Contributor Author

atugushev commented Aug 13, 2019 •
edited
Loading

@chrahunt

Would it be straightforward (and worthwhile) to special-case this to indicate that pip is being modified because it is listed as a dependency (and maybe what it is listed as a dependency of)?

Thanks for reviewing this, Christopher! Appreciated it. I'd prefer to fix that case in the next PR.

chrahunt
chrahunt reviewed Aug 14, 2019
View reviewed changes
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more minor comments.

pradyunsg
pradyunsg requested changes Aug 14, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this in a hurry -- please don't mind my repetition.

Comments starting with "nit: " are optional suggestions. If you disagree with them, that's cool -- they're not worth spending energy debating over. ;)

@atugushev
Fix bypassed pip upgrade warning on Windows
9a317d3
@atugushev
Address review comments
a1fa84e 
Handle the case of invoking pip via pip3 and pip3.7
@atugushev
Address review comments
9497900 
Fix typos and remove unneeded assertions.
@atugushev
Copy link
Contributor Author

atugushev commented Aug 14, 2019 •
edited
Loading

Thank you guys for the feedback! I've rebased to the latest master as suggested @chrahunt and added more fixes.

@atugushev
Copy link
Contributor Author

Note, i've added network mark to all tests, since them need to upgrade/downgrade pip. If you think we can achieve it without the network i'd love to get any ideas.

@atugushev
Address review comments
173761c 
Rebased to the latest master
Remove unneeded assertions
Use create_basic_wheel_for_package
Couple other nitpicks
chrahunt
chrahunt reviewed Aug 16, 2019
View reviewed changes
@atugushev
Addrees review comments
f9fc667 
Fix typos
Use script.pip instead of script.run
chrahunt
chrahunt approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atugushev atugushev mentioned this pull request Aug 21, 2019
Closed
@atugushev
Copy link
Contributor Author

Kindly pinging @pradyunsg :) Is there any other issues with this PR?

@pradyunsg
Copy link
Member

Appreciate the ping @atugushev! :)

@pradyunsg pradyunsg merged commit d2b7082 into pypa:master Aug 25, 2019
@atugushev atugushev deleted the fix-issue-6841 branch August 25, 2019 18:16
@atugushev atugushev mentioned this pull request Aug 26, 2019
Closed
@atugushev atugushev mentioned this pull request Sep 8, 2019
Open
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Sep 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 25, 2019
@pradyunsg
Copy link
Member

I'm suggesting that we revert this here based on discussion here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrahunt chrahunt chrahunt approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip upgrade warning is bypassed when pip is a dependency
4 participants
@atugushev @pradyunsg @chrahunt @benoit-pierre