Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an unused argument #6700

Merged
merged 3 commits into from
Jul 13, 2019
Merged

Remove an unused argument #6700

merged 3 commits into from
Jul 13, 2019

Conversation

pradyunsg
Copy link
Member

Related to #6050

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jul 12, 2019
@pradyunsg pradyunsg mentioned this pull request Jul 12, 2019
Closed
@pradyunsg
Python 2 support is not painful. :)
8e57084 
/s because obviously I'm being sarcastic.
@pradyunsg pradyunsg added C: tests Testing and related things type: refactor Refactoring code labels Jul 12, 2019
@xavfernandez
Tweak utime call
3e8ccc9 
Apparently, times is not a keyword argument either in Python 2.7 ;)
@xavfernandez
Copy link
Member

@pradyunsg I took the liberty to tweak utime call, I hope you don't mind me stealing some of your Python 2 compatibility pleasure.

@pradyunsg
Copy link
Member Author

pradyunsg commented Jul 13, 2019 •
edited
Loading

Oh come on. Once that AWS-CLI stuff is fixed, I really want to just skip all this stuff.

Thanks for fixing that issue Xavier!

@pradyunsg pradyunsg merged commit 16ef685 into pypa:master Jul 13, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 12, 2019
@pradyunsg pradyunsg deleted the tests/remove-path-touch-times branch September 30, 2019 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradyunsg @xavfernandez