Only revalidate /simple/ pages instead of caching for 10 minutes #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, @pradyunsg it looks like mypy is broken? I don't think my change could have caused that so I'm guessing it's broken on |
|
It is. There's been a new mypy release and my bodge isn't working anymore. Let's go ahead and pin to the older release (0.620) for now. I get an email on every mypy release from Travis CI anyway -- I'll just swap that out with https://libraries.io. |
|
master is green. |
dstufft
force-pushed
the
zero-cache-time-simple
branch
from
5610ca5
to
dcc3c16
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the
max-ageon a request to/simple/to 0, which will bypass the cache during the request phase, but will still utilize it for creating and fulfilling conditional HTTP requests. This will allow us to no longer confuse end users when they dopip install ... && twine upload ... && pip install ..while still minimizing bandwidth as much as we can.This will increase the time for repeat pip installs, since we'll have to do a round trip for the conditional request instead of serving directly out of the cache, however that is the common case anyways (we only cached these responses for up to 10 minutes anyways) so it's not likely to be a very big deal, while the confusion caused by the cache was a persistent problem.
Fixes #5670