Restrict install time dependency warnings to directly-dependant packages #5457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
type: enhancement
pradyunsg
added
T: bugfix
and removed
type: enhancement
cjerdonek
reviewed
May 30, 2018
|
|
||
|
|
||
| def check_package_set(package_set): | ||
| # type: (PackageSet) -> CheckResult | ||
| def check_package_set(package_set, whitelist=None): |
There was a problem hiding this comment.
Since you're only using whitelist to check membership, it might make more sense for this to be a set.
| @@ -52,6 +56,10 @@ def check_package_set(package_set): | |||
| missing_deps = set() # type: Set[Missing] | |||
| conflicting_deps = set() # type: Set[Conflicting] | |||
|
|
|||
| # Ignore dependency when it's not in the whitelist. | |||
| if whitelist is not None and package_name not in whitelist: | |||
There was a problem hiding this comment.
For reasons of elegance, it would be nice if you didn't have to repeat the None check in each iteration of the loop. An alternative to passing a list or set would be to pass a should_ignore() function. The first couple lines of your function could then be:
if should_ignore is None:
should_ignore = lambda package_name: Falsemeaning your conditional would be:
if should_ignore(package_name):
continue
|
Thanks, Pradyun! I just noticed check_package_set()’s docstring should be
updated after changing whitelist to should_ignore().
…On Thu, May 31, 2018 at 10:56 AM Dustin Ingram ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5457 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVt7gbQNz3A_LLQJE7h6A7sB3AXdw_zks5t4C7WgaJpZM4US8qH>
.
|
|
@pypa/pip-committers I'm happy to merge this if no one else has any issues with this. |
pradyunsg
force-pushed
the
check/only-check-requirements-modified
branch
from
70c2acf
to
a25e941
Compare
pradyunsg
force-pushed
the
check/only-check-requirements-modified
branch
from
9c5b254
to
5842476
Compare
pradyunsg
force-pushed
the
check/only-check-requirements-modified
branch
from
5842476
to
161e8bd
Compare
|
Merging since I am happy with this PR. :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the install-time-warnings to check the consistency of just the packages to-be-installed in that run and packages that directly depend on the ones that are to-be-installed; instead of the current behavior of checking the entire package set.
This should resolve #5196.
/cc @di @cjerdonek