-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open up plat/abi/impl options to install --target
#5404
Merged
pradyunsg
merged 1 commit into
pypa:master
from
lorencarvalho:feature/platforms_for_target
Aug 12, 2018
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Allows dist options (--abi, --python-version, --platform, --implementation) when installing with --target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ | |
import pytest | ||
|
||
from pip._internal import pep425tags | ||
from pip._internal.cli.status_codes import ERROR | ||
from pip._internal.cli.status_codes import ERROR, SUCCESS | ||
from pip._internal.models.index import PyPI, TestPyPI | ||
from pip._internal.utils.misc import rmtree | ||
from tests.lib import ( | ||
|
@@ -679,6 +679,66 @@ def test_install_package_with_target(script): | |
assert singlemodule_py in result.files_updated, str(result) | ||
|
||
|
||
def test_install_nonlocal_compatible_wheel(script, data): | ||
target_dir = script.scratch_path / 'target' | ||
|
||
# Test install with --target | ||
result = script.pip( | ||
'install', | ||
'-t', target_dir, | ||
'--no-index', '--find-links', data.find_links, | ||
'--only-binary=:all:', | ||
'--python', '3', | ||
'--platform', 'fakeplat', | ||
'--abi', 'fakeabi', | ||
'simplewheel', | ||
) | ||
assert result.returncode == SUCCESS | ||
|
||
distinfo = Path('scratch') / 'target' / 'simplewheel-2.0-1.dist-info' | ||
assert distinfo in result.files_created | ||
|
||
# Test install without --target | ||
result = script.pip( | ||
'install', | ||
'--no-index', '--find-links', data.find_links, | ||
'--only-binary=:all:', | ||
'--python', '3', | ||
'--platform', 'fakeplat', | ||
'--abi', 'fakeabi', | ||
'simplewheel', | ||
expect_error=True | ||
) | ||
assert result.returncode == ERROR | ||
|
||
|
||
def test_install_nonlocal_compatible_wheel_path(script, data): | ||
target_dir = script.scratch_path / 'target' | ||
|
||
# Test a full path requirement | ||
result = script.pip( | ||
'install', | ||
'-t', target_dir, | ||
'--no-index', | ||
'--only-binary=:all:', | ||
Path(data.packages) / 'simplewheel-2.0-py3-fakeabi-fakeplat.whl' | ||
) | ||
assert result.returncode == SUCCESS | ||
|
||
distinfo = Path('scratch') / 'target' / 'simplewheel-2.0.dist-info' | ||
assert distinfo in result.files_created | ||
|
||
# Test a full path requirement (without --target) | ||
result = script.pip( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above. |
||
'install', | ||
'--no-index', | ||
'--only-binary=:all:', | ||
Path(data.packages) / 'simplewheel-2.0-py3-fakeabi-fakeplat.whl', | ||
expect_error=True | ||
) | ||
assert result.returncode == ERROR | ||
|
||
|
||
def test_install_with_target_and_scripts_no_warning(script, common_wheels): | ||
""" | ||
Test that installing with --target does not trigger the "script not | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.check_supported_wheels
can move to the outer conditional -- saves creating a Wheel instance. :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
check_supported_wheels
boolean is the gate to whether or not we raise the incompatibility exception (based on whether--target
was used duringinstall
). So I don't think it can move.