Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix safe_name behavior if package name includes dot #5052

Closed
wants to merge 1 commit into from
Closed

fix safe_name behavior if package name includes dot #5052

wants to merge 1 commit into from

Conversation

jt1
Copy link

@jt1 jt1 commented Mar 3, 2018 •
edited
Loading

Dot was not replaced with a single - in pip._vendor.pkg_resources.safe_name
This caused inconsistent behavior when installing package with dot in their name:

$ pip install fluent-logger
$ pip install fluent.logger

See #5021

@jt1 jt1 closed this Apr 2, 2018
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jt1