Warn about broken dependencies during pip install #5000
Conversation
…esolver/warn-after-resolution
While there is no change in functionality, this change makes it possible to reuse the pip check logic by uncoupling it from the Distribution objects.
- Move get_installed_distributions call into operations.check - Use a named tuple, instead of a normal tuple
Also, add --no-warn-conflicts option to allow supressing the error messages generated.
pradyunsg
added
type: feature request
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
…esolver/warn-after-resolution
|
@pradyunsg Are you still hoping to get this in pip 10? It looks like it needs some work. |
|
I do. I'm actually working on this rn. =) |
|
Okay. One more thing - markers. |
More robust with weird requirements that can't be directly compared for some reason (like markers).
|
Great. Code is good. Now, docs and news next. Then a review (maybe?). |
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
|
I'm skipping the documentation here because I'm not very sure whether it's needed or what it can say. If someone points out that they want information or more details, I imagine we'll get to know during the beta period. |
|
@pradyunsg hi! After this change, are there any cases left were it's still necessary to run |
|
Running pip check when there's a broken dependency graph, will result in an exit code of 1. This PR doesn't change the exit code of pip install. So, if you're running pip check today, keep doing that. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
(come on, I have to squat this number)
Fixes: #4828
Depends on: #4978, #4925, #4977
CF: #4820
I'm happy to take feedback on this over at pradyunsg#1.