Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(lots of) Misc Cleanups #4651

Closed
wants to merge 19 commits into from
Closed

(lots of) Misc Cleanups #4651

wants to merge 19 commits into from

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Aug 6, 2017 •
edited
Loading

Random changes that didn't make it into other PRs.

(edited on 3-Oct-17)

@pradyunsg
Improve imports
10546ce
@pradyunsg
Improve control statement headers
09cf8eb 
This is done by Introducing variables to hold the value or bringing the conditional onto a single line where possible.
@pradyunsg
SImplify has_requirement
5d52c2b
@pradyunsg
(un)Wrap lines for readability
c0317e5
@pradyunsg
Introduce variables to simplify
f6c0762
@pradyunsg
Unwrap a line
4ad69e9
@pradyunsg
Adopt the trailing closing paren form
239be10 
This is the most common form of closing, based on my rudementary grep on the codebase.
@pradyunsg
Rewrap
528780e
@pradyunsg
Simplify certain portions
280111b
@pradyunsg
Rewrap
1e0e912
@pradyunsg
Improve docstrings and comments
1a38963
@pradyunsg
Add/Remove empty lines
a617339
@pradyunsg
Auto Concatenate strings
7b4321f
@pradyunsg
Add a missed trailing paren change
c37f043
@pradyunsg
Auto Concatenate strings
f7fa6f5
@pradyunsg
Revert "Auto Concatenate strings"
22afc11 
This reverts commit 7b4321f.
@pradyunsg
Add a paren I missed
56219c8
@pradyunsg pradyunsg added type: maintenance Related to Development and Maintenance Processes skip news Does not need a NEWS file entry (eg: trivial changes) labels Aug 6, 2017
@pradyunsg pradyunsg self-assigned this Aug 6, 2017
@pradyunsg pradyunsg requested a review from a team August 6, 2017 15:13
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Aug 10, 2017
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Aug 10, 2017
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Aug 31, 2017
@xavfernandez
Copy link
Member

Splitting it by category would help reviewing it :o

@pradyunsg
Copy link
Member Author

Splitting it by category would help reviewing it :o

This was just a whole set of changes that I had stashed up over the past few weeks; I just stash popped all of them and put them here so that I don't forget about these. :P

I thought I had mentioned this in OP; evidently not.

Nonetheless, better late than never -- I'll be making separate PRs for basically all of these whenever I find the time to do so.

@pradyunsg pradyunsg removed their assignment Oct 5, 2017
@pradyunsg pradyunsg mentioned this pull request Nov 7, 2017
Merged
@pradyunsg
Copy link
Member Author

Closing. #5425 will do all of this. :)

@pradyunsg pradyunsg closed this May 27, 2018
@pradyunsg pradyunsg deleted the misc/cleanups branch May 27, 2018 10:09
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation needs rebase or merge PR has conflicts with current master skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pradyunsg @BrownTruck @xavfernandez @pypa-bot