Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Improve build speeds and upgrade PyPy version #4590

Merged
merged 6 commits into from
Jul 2, 2017

Conversation

pradyunsg
Copy link
Member

Firstly, sorry for the mess I created with #4584, #4585, #4586. Won't happen again.
Secondly, thanks @xoviat for pointing out that the default PyPy on Travis CI was very old.

Closes #4587, since this is a cleaner approach.


With that out of the way, this PR:

  • switches to Container Based infrastructure to speed up all build jobs
  • upgrades the version of PyPy to the newest that Travis seems to provide [1]

These 2 combined seem to bring down the CI time from what's a 45 minute CI today [2].

@pradyunsg pradyunsg added C: automation Automated checks, CI etc type: maintenance Related to Development and Maintenance Processes skip news Does not need a NEWS file entry (eg: trivial changes) labels Jul 1, 2017
@pradyunsg pradyunsg self-assigned this Jul 1, 2017
@pradyunsg pradyunsg requested a review from dstufft July 1, 2017 19:56
@pradyunsg
Copy link
Member Author

Awesome! The Travis Job completed successfully in under 25 minutes.

@@ -19,7 +21,7 @@ matrix:
- env: TOXENV=py37
python: nightly
- env: TOXENV=pypy
python: pypy
python: pypy-5.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pypy-5.8.0 works?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give it a shot.

Copy link
Member Author

@pradyunsg pradyunsg Jul 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstufft Nope. https://travis-ci.org/pradyunsg/pip/jobs/249185227

There's pypy3.5-5.8.0 which failed because of some directory not being resolved properly... https://travis-ci.org/pradyunsg/pip/jobs/249044310

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Okay.

@pradyunsg
Copy link
Member Author

@dstufft Is this good to go then?

@dstufft dstufft merged commit d2574ef into pypa:master Jul 2, 2017
@pradyunsg pradyunsg deleted the ci/upgrade-pypy branch July 2, 2017 18:45
@pradyunsg
Copy link
Member Author

pradyunsg commented Jul 6, 2017

It's interesting how the same job can take 8 minutes or 22 minutes; if you simply re-run it.

@pradyunsg pradyunsg mentioned this pull request Oct 5, 2017
12 tasks
@pradyunsg pradyunsg removed their assignment Oct 5, 2017
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: automation Automated checks, CI etc skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants