-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis: Improve build speeds and upgrade PyPy version #4590
Conversation
Awesome! The Travis Job completed successfully in under 25 minutes. |
@@ -19,7 +21,7 @@ matrix: | |||
- env: TOXENV=py37 | |||
python: nightly | |||
- env: TOXENV=pypy | |||
python: pypy | |||
python: pypy-5.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think pypy-5.8.0
works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll give it a shot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dstufft Nope. https://travis-ci.org/pradyunsg/pip/jobs/249185227
There's pypy3.5-5.8.0
which failed because of some directory not being resolved properly... https://travis-ci.org/pradyunsg/pip/jobs/249044310
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Okay.
@dstufft Is this good to go then? |
It's interesting how the same job can take 8 minutes or 22 minutes; if you simply re-run it. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Firstly, sorry for the mess I created with #4584, #4585, #4586. Won't happen again.
Secondly, thanks @xoviat for pointing out that the default PyPy on Travis CI was very old.
Closes #4587, since this is a cleaner approach.
With that out of the way, this PR:
These 2 combined seem to bring down the CI time from what's a 45 minute CI today [2].