Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add all wheels option to pip download Fixes #4422 #4423

Closed
wants to merge 1 commit into from
Closed

add all wheels option to pip download Fixes #4422 #4423

wants to merge 1 commit into from

Conversation

graingert
Copy link
Contributor

No description provided.

genjudev
genjudev reviewed Apr 6, 2017
View reviewed changes
pip/index.py Outdated
@@ -252,6 +256,9 @@ def sort_path(path):

return files, urls

def _supported(wheel):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need self here

Copy link
Contributor Author

@graingert graingert Apr 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>.<

@xavfernandez
Copy link
Member

This PR does not implement #4422 as pip download is still downloading a single file.
It is apparently aimed at making PackageFinder more general to allow an easier unsupported use in piptools.

@graingert graingert mentioned this pull request Apr 10, 2017
Closed
@pradyunsg
Copy link
Member

I just closed #4422 under the rationale that this isn't something that is a common enough use case for pip to support. Further, this PR does not add the functionality as requested in #4422.

I'm closing this. Feel free to re-open this PR if you feel otherwise.

@pradyunsg pradyunsg closed this Jun 27, 2017
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@genjudev genjudev genjudev left review comments

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@graingert @xavfernandez @pradyunsg @genjudev