Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate --egg #3956

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Deprecate --egg #3956

merged 1 commit into from
Sep 7, 2016

Conversation

dstufft
Copy link
Member

@dstufft dstufft commented Sep 7, 2016

Fixes #1749
Fixes #1320
Closes #3711

@sigmavirus24
Copy link
Member

:shipit:

@pfmoore
Copy link
Member

pfmoore commented Sep 7, 2016

@dstufft - any idea why this didn't get checked with appveyor? It's no different to #3950 as far as I can see, but that one has both travis and appveyor checks (with only travis being required) and this one only has travis :-(

@dstufft
Copy link
Member Author

dstufft commented Sep 7, 2016

@pfmoore Um, I don't know. Looking at the logs Appveyor returned an error:

Cache-Control: no-cache
Content-Length: 48
Content-Type: application/json; charset=utf-8
Date: Wed, 07 Sep 2016 14:40:37 GMT
Expires: -1
Pragma: no-cache
Server: Microsoft-IIS/8.5
X-AspNet-Version: 4.0.30319
X-Powered-By: ASP.NET
{"message":"Pull request #3956 does not exist."}

Except I don't know why it returned a 404. This PR obviously does exist.

@dstufft
Copy link
Member Author

dstufft commented Sep 7, 2016

To be clear, the reason it doesn't list Appveyor at all is because Appveyor never reported a status. Once you mark a service as required then Github will automatically add a pending status to every PR for that, but for non required services it waits until the service reports a status.

@pfmoore
Copy link
Member

pfmoore commented Sep 7, 2016

OK, weird. I'll ping appveyor about it. Thanks.

@pfmoore
Copy link
Member

pfmoore commented Sep 7, 2016

Redelivering the webhook request seems to have fixed it - looks like it was just some sort of intermittent glitch.

@dstufft dstufft merged commit 403e398 into pypa:master Sep 7, 2016
@dstufft dstufft deleted the remove-egg branch September 7, 2016 20:44
@mithrandi
Copy link

Occasionally it seems GitHub delivers webhooks for new PRs before the PR object is fully visible in the API; I've seen inconsistencies like this before (maybe some caching / eventual consistency issue?).

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--egg ignored when wheels available Deprecate --egg pip install --egg break's pip's dependency resolution
4 participants