Pl.pip install additional options #3760
Conversation
|
@xavfernandez @dstufft Is there anything blocking this PR from being merged? It's been languishing in what I consider a "ready" state for at least a month now, accumulated multiple merge conflicts, and even been auto-closed. What exactly is the process for getting this upstream? |
patricklaw
force-pushed
the
pl.pip-install-additional-options
branch
from
662a5ac
to
15d5c2a
Compare
| $ pip download SomePackage | ||
| $ pip download -d . SomePackage # equivalent to above | ||
| $ pip download --no-index --find-links=/tmp/wheelhouse -d /tmp/otherwheelhouse SomePackage | ||
| 1. Download a package and all of its dependencies |
There was a problem hiding this comment.
It's better to use #. notation to let sphinx do the numbering (so you don't have to modify all the following examples when you delete the first one)
There was a problem hiding this comment.
I tried to do this, but each time I did the local render of the docs it didn't work (it just rendered all 1.s). Am I missing something?
There was a problem hiding this comment.
Your :: are breaking the numbered list into several one-item lists, you should indent the :: (and their code) more.
|
@patricklaw There is no process :) I personnally like it, but I'd rather have other pip dev take a look at it before it is merged cc (@dstufft @pfmoore ?) |
patricklaw
force-pushed
the
pl.pip-install-additional-options
branch
from
15d5c2a
to
9c833a3
Compare
|
Thanks for the feedback @xavfernandez, pushed fixes |
|
I'm OK with this. I haven't had time to do more than scan the code, but there don't seem to be any glaring issues, and @xavfernandez has done a full review, so I'm +1 on this going in. |
|
@xavfernandez is @pfmoore's sign-off sufficient to merge now? It sounds like this is ready to land, and I'd like to avoid more merge conflicts (not to mention consume the change!) |
|
pinging on this since it seems to have gone stale - would love to see this land. |
| @@ -42,10 +55,66 @@ Options | |||
| Examples | |||
| ******** | |||
|
|
|||
| #. Download a package and all of its dependencies | |||
| #. Download a package and all of its dependencies | |||
|
Probably don't need to worry about the doc nits that I pointed out |
| ``--implementation``, and ``--abi`` options provides the ability to fetch | ||
| dependencies for an interpreter and system other than the ones that pip is | ||
| running on. ``--only-binary=:all:`` is required when using any of these | ||
| options. It is important to note that these options all default to the |
There was a problem hiding this comment.
Same on the line above, after running on.
|
@patricklaw except some space nitpicking this seems ready to go in pip 8.2 👍 |
With the --platform option, a user can download wheels with a different platform than that of the local machine running the command. With the --python-version option, a user can download wheels that are explicitly compatible with a specific Python interpreter version. This functionality is meant for utilities that gather dependencies and prepare distributions for other platforms.
Add thorough tests, usage documentation, and handle some merge issues.
patricklaw
force-pushed
the
pl.pip-install-additional-options
branch
from
9c833a3
to
72d9fd1
Compare
|
It would be cool to add these to install and wheel too. Would potentially deprecate some of the work I've done in https://github.com/asottile/pip-custom-platform |
|
@patricklaw Thanks a lot :) |
lock
bot
added
the
auto-locked
This is a continuation of #3092