Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speeding up test_uninstall_editable_with_source_outside_venv by using pip-test-package instead of virtualenv #1727

Closed
wants to merge 1 commit into from
Closed

speeding up test_uninstall_editable_with_source_outside_venv by using pip-test-package instead of virtualenv #1727

wants to merge 1 commit into from

Conversation

grzn
Copy link
Contributor

@grzn grzn commented Apr 16, 2014

before:
1 passed, 12 deselected in 218.41 seconds

after:
1 passed, 12 deselected in 3.42 seconds

@grzn grzn changed the title refactoring warning of insecure access and adding tests speeding up test_uninstall_editable_with_source_outside_venv by using pip-test-package instead of virtualenv Apr 16, 2014
@grzn
Copy link
Contributor Author

grzn commented Apr 16, 2014

the third task of #1721

… pip-test-package instead of virtualenv

before:
1 passed, 12 deselected in 218.41 seconds

after:
1 passed, 12 deselected in 3.42 seconds
) in result2.files_created, list(result2.files_created.keys())
result3 = script.pip('uninstall', '-y', 'virtualenv', expect_error=True)
result3 = script.pip('uninstall', '-y', 'pip-test-package', expect_error=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give this a line break to fix pep, please

/tests/functional/test_uninstall.py:224:80: E501 line too long (82 > 79 characters)

https://travis-ci.org/pypa/pip/builds/23133838

Cheers

@Ivoz Ivoz added the tests label Apr 18, 2014
@Ivoz Ivoz closed this Apr 21, 2014
@Ivoz
Copy link
Contributor

Ivoz commented Apr 21, 2014

Merged in develop

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: tests Testing and related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants