-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce ruff/pyupgrade rules (UP) #12936
Conversation
558b689
to
dd9e3ad
Compare
FWIW, enabling pyupgrade rules by default was discussed and the sentiment appeared to be to run it on an ad-hoc basis not to enforce it: #11944 (comment) |
dd9e3ad
to
45d9238
Compare
UP031 Use format specifiers instead of percent format
UP037 Remove quotes from type annotation
45d9238
to
3d7237c
Compare
Would you like me to remove |
I'm personally supportivel of UP being a selected rule set, and turning off any particular rules if they're found to be problematic. But pip maintainers may have different opinions (as linked). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this. We can come back can remove things if we want to.
As part of repo-review suggestions:
https://learn.scientific-python.org/development/guides/repo-review/?repo=pypa%2Fpipx&branch=main