In tests use prerelease version of cffi for Python 3.13 #12776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
Jun 20, 2024
pradyunsg
force-pushed
the
use-prerelease-version-of-cffi
branch
from
b4b45b6 to
42c8a61
Compare
|
Do you know off-hand if 3.12.4 has the urlunsplit fix? |
|
Based on https://docs.python.org/3/whatsnew/changelog.html#python-3-12-4-final, apparently yes. |
|
CI is now green, please merge when ready |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cffi is a transative dependency (dependency of cryptography) in the test suite, there is a prerelease now compatible with Python 3.13 so we can use that instead of building from github source.
But it will not be sourced unless there is a requirement that explicitly includes a prerelease marker.