Upgrade truststore to 0.9.1 #12707
Upgrade truststore to 0.9.1 #12707
Conversation
|
Thank you for the review @uranusjr! |
|
@sethmlarson Could you rebase/merge in main to pull in the CI fixes? |
sethmlarson
force-pushed
the
truststore-0.9.1
branch
from
b13ebec to
44c2f4a
Compare
|
@ichard26 Done! |
|
Strange that pre-commit CI is failing, but could you also fix that? (I would fix it myself, but I'm not a pip committer and I can't push to your branch, sorry.) |
sethmlarson
force-pushed
the
truststore-0.9.1
branch
from
44c2f4a to
2000d38
Compare
|
@ichard26 Fixed the issue and repushed, sorry for that! |
|
To committers, any objections if this lands for 24.1 final? This was supposed to be in the release, but undiscovered Python 3.13 incompatibilities led to a revert. If it's too risky, I'd like to see this land in 24.2. |
|
That would be up to @pradyunsg who is the release manager for 24.1. Given we're on our 2nd beta and we're approaching the final release, it may be too risky to land this change. Is this vendoring bump necessary for Python 3.13 support? |
|
@ichard26 Unfortunately so, the pull request that fixes the issue upstream hasn't been merged: python/cpython#118669 |
|
I will schedule this for 24.1 so @pradyunsg will take a look at this, but it's up to them to decide whether this goes in or not. |
Follow-up from #12662 which fixes the issue discovered after 0.9.0 was vendored (thanks @notatallshaw for reporting that issue!)