Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI Tests on both MacOS Arm and x86 #12593

Closed

Conversation

notatallshaw
Copy link
Member

@notatallshaw notatallshaw commented Mar 24, 2024

It occured to me that pip tests currently only run on MacOS x86, which at this point could be considered problematic.

Checking the documentation (https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories) it appears that you must manually specify which version of MacOS you want to get the Arm version.

This probably could be done a little more elegantly but first I wanted to see if all tests would pass on Arm.

@notatallshaw notatallshaw marked this pull request as ready for review March 24, 2024 04:13
@notatallshaw
Copy link
Member Author

Well they pass, and complete faster than any of the other workers, so seems like there's little reason not to enable?

Marking ready for review.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@pradyunsg pradyunsg added the S: awaiting response Waiting for a response/more information label Apr 7, 2024
@notatallshaw notatallshaw changed the title Run CI Tests on MacOS Arm Run CI Tests on both MacOS Arm and x86 Apr 9, 2024
@notatallshaw
Copy link
Member Author

Pip's macos-latest runner is now macos-14 causing pip CI to fail: https://github.com/pypa/pip/actions/runs/8825862850/job/24230722241

This PR supports continuing to test x86 and ARM, where as my alternative PR fixes pip CI just for ARM: #12617

@notatallshaw notatallshaw force-pushed the run-ci-tests-on-macos-arm branch 2 times, most recently from 9d59d97 to 70826ad Compare April 25, 2024 02:18
@notatallshaw
Copy link
Member Author

This failure is new:

FAILED tests/functional/test_install.py::test_vcs_url_urlquote_normalization - pip._internal.exceptions.InstallationSubprocessError: bzr checkout --lightweight --quiet http://bazaar.launchpad.net/%7Edjango-wikiapp/django-wikiapp/release-0.1 /private/var/folders/hv/qqnln7cj5cg0n48fcrlmbz4m0000gn/T/pytest-of-runner/pytest-1/popen-gw1/test_vcs_url_urlquote_normaliz0/cache/release-0.1 exited with 3

I guess it's a flaky test? I have no way to try to reproduce.

@notatallshaw
Copy link
Member Author

notatallshaw commented Apr 25, 2024

I guess it's a flaky test? I have no way to try to reproduce.

Yup, I forced CI to rerun and this time the test passed.

@notatallshaw notatallshaw force-pushed the run-ci-tests-on-macos-arm branch 2 times, most recently from a61325a to 1bcc4f3 Compare April 25, 2024 22:57
@notatallshaw notatallshaw mentioned this pull request Apr 28, 2024
@pradyunsg pradyunsg removed the S: awaiting response Waiting for a response/more information label Apr 28, 2024
@notatallshaw notatallshaw force-pushed the run-ci-tests-on-macos-arm branch 2 times, most recently from 8abf028 to 95c319e Compare April 30, 2024 04:30
@notatallshaw
Copy link
Member Author

So this PR is updated to run MacOS 12 (x86) on all versions of Python, and MacOS Latest (M1) on Python versions >= 3.10, as 3.8 and 3.9 have a failing test (test_uninstall_editable_from_usersite).

@notatallshaw
Copy link
Member Author

notatallshaw commented Jun 28, 2024

FWIW, I think this PR is worth merging, macos-latest runs much faster so it doesn't slow down the CI, and either someone else can fix Python 3.8 and 3.9 tests on MacOS ARM, or eventually they will go end of life and it won't be an issue any more.

@notatallshaw
Copy link
Member Author

Can a maintainer yay or nay this, I'll close the PR if nay.

To summaraize:

  • CI tests are currently running against macos-12 (x86)
  • This PR adds CI macos-latest (arm) for Python 3.10+
  • Last I checked macos-latest (arm) fails test_uninstall_editable_from_usersite on Python 3.8 and 3.9, I have no way to locally reproduce

@notatallshaw
Copy link
Member Author

I'm closing this PR as I don't like keeping PRs open and stale.

It's very easy for someone else to recreate, and I've made a GitHub issue to be tracked #12908

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants