Prep removal of importlib.resources.open_text.
#12462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `importlib.resources.open_text` was deprecated in Python 3.11 and is removed in 3.13.
pradyunsg
approved these changes
Jan 5, 2024
|
FWICT there is CI bitrot over the last ~5 days. This PR has similar small footprint / scope and similar failures for example: https://github.com/pypa/pip/actions/runs/7379405369?pr=12457 @pradyunsg am I off here with respect to CI / CI state? |
|
Ah, perhaps #12458 fixes the CI issues here. |
|
Yea, we need to fix the CI at some point soon. I'm trying to avoid doing too much OSS stuff while I'm with family, but I expect I'll spend time on the CI situation when I get back from vacation. |
|
Alright @pradyunsg, I merged in @sbidoul's CI fixes, did a typing fix of my own for this PR and things look good now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
importlib.resources.open_textwas deprecated in Python 3.11 and isremoved in 3.13.