Fix ZSH completion script #12173
Merged
Fix ZSH completion script #12173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any new progress? |
|
@Freed-Wu can you check why CI is red? |
|
I fixed the broken test in my fork, and added news entry as well (which should fix CI). The test was failing because of a wrong indentation of the expected result. See I can also confirm that the this PR does fix completion, thanks! Looking forward to seeing this merged 🚀 |
pradyunsg
reviewed
Oct 6, 2023
|
@dtrifiro I rename your |
|
Merging based on the user confirmation that this works well! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.