Add permission check before configuration #12089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmoore
reviewed
Jun 14, 2023
|
Need to fix the CI failures. |
pfmoore
requested changes
Jun 19, 2023
Yes, I need it. |
|
I think these code in tests\functional\test_wheel.py::test_pip_wheel_ext_module_with_tmpdir_inside() makes the CI test failed: |
|
CI Tests passed. |
uranusjr
reviewed
Jun 29, 2023
uranusjr
reviewed
Jun 29, 2023
uranusjr
reviewed
Jun 29, 2023
uranusjr
reviewed
Jun 29, 2023
uranusjr
approved these changes
Jun 29, 2023
|
@uranusjr CI Test "Windows 3.11" didn't pass |
pfmoore
approved these changes
Jun 29, 2023
It's a known intermittent issue. I've restarted the failed jobs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I said in this issues and this issues, there will be an error because we have no permission to write into "C:\Program Files\WindowsApps\Pythoninmicrosoftstorepath\pip.ini'" , such as:
'''
[Errno 13] Permission denied:"C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.1 1.752.0_x64__qbz5n2kfra8p0\pip.ini"
'''
I fix this by checking your permission before write into the configuration.