-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendoring updates for 23.1 #11916
Vendoring updates for 23.1 #11916
Conversation
It's not going to be my day, I can see. If the "Create RAMDisk" step is failing, I refuse to believe that's my fault. I'll let all the other checks run, and then try re-running the failed one in case the issue is intermittent, rather than a problem with the Windows worker. |
I think Github changed something about the environment that broke RAM disks for us (again). |
I've seen these RAM disk errors more frequently recently. Usually restarting the failed jobs is sufficient, which I just did here. |
I sorted out the setuptools patch (I think) so I added that. |
... and tenacity. @pradyunsg All I did was:
Is that basically correct? I really don't like manually editing patch files, but given all of the changes in the working copy, editing the file and doing |
... and that's pygments done. So I think I now have all of the vendoring done for 23.1, assuming nothing else changes before the release. |
@@ -1 +1 @@ | |||
Update pkg_resources (via setuptools) to 65.6.3 | |||
Upgrade setuptools to 67.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change intentional? ("Update pkg_resources (via setuptools)" becoming "Upgrade setuptools")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a consequence of the automation handling things slightly differently than the manual upgrade I'd done earlier!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I assume - I certainly didn't do anything explicit to cause this to happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Skips
pygments
,tenacity
andsetuptools
, as they all need updates to the patches. @pradyunsg can you take a look please?