Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade resolvelib to 0.9.0 #11783

Merged
merged 4 commits into from
Feb 7, 2023
Merged

Conversation

pradyunsg
Copy link
Member

No description provided.

@pradyunsg pradyunsg added the project: vendored dependency Related to a vendored dependency label Feb 6, 2023
@pradyunsg pradyunsg modified the milestones: 23.2, 23.1 Feb 6, 2023
This is _technically_ possible with the API, and accounting for that
enables the resolver to evolve with this information.
This is a newer method on resolvelib's end for reporting when a
candidate is rejected.
@pradyunsg pradyunsg merged commit 5a9efde into pypa:main Feb 7, 2023
@pradyunsg
Copy link
Member Author

Merging this without reviews since this seems like a fairly safe change.

The only thing that's "maybe worth discussion" here is the use of math.inf rather than 1.0 when we don't have any information for the identifier in get_preference; I think math.inf is the right choice tho.

@pradyunsg pradyunsg deleted the resolvelib-update branch February 7, 2023 12:00
@notatallshaw
Copy link
Member

FYI my initial testing shows some known problematic backtracking situations improve significantly from this, but some remain problematic.

On the whole I suspect a win 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
project: vendored dependency Related to a vendored dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants