-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip dist if metadata does not have a valid name #11353
Skip dist if metadata does not have a valid name #11353
Conversation
@@ -2,6 +2,15 @@ | |||
from typing import Any, Optional, Protocol, cast | |||
|
|||
|
|||
class BadMetadata(ValueError): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also derive from PipError?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the convention is. This is supposed to be somewhat internal to the metadata
subpackage and shouldn’t be uncaught.
Thanks for writing this. I was just about to have a look :) |
Any thoughts on this, fellow maintainers? |
I'm good with this. A test would be nice. |
Does this warrant a patch release before Python 3.11 is released? |
I'd be cautious about trying to get another pip release in, as 3.11rc1 has been released. I wouldn't even consider it without getting RM approval, TBH. |
This probably does not affect those using pip in a “normal” Python environment, but I’m not sure if having a release would make things easier for Fedora. |
I plan to patch our pip as soon as this is merged. But I am not sure how likely this is to happen elsewhere. A release before Python 3.11 final is released might be the safest option. |
Merging this now, we can always modify exception inheritance later. |
Fix #11352.