Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring upgrade #10815

Merged
merged 15 commits into from
Jan 27, 2022
Merged

Vendoring upgrade #10815

merged 15 commits into from
Jan 27, 2022

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Jan 21, 2022

Closes #10708

@pradyunsg pradyunsg added this to the 22.0 milestone Jan 21, 2022
@pradyunsg pradyunsg marked this pull request as ready for review January 25, 2022 18:23
@pradyunsg pradyunsg mentioned this pull request Jan 26, 2022
@hukkin
Copy link
Contributor

hukkin commented Jan 26, 2022

Hi @pradyunsg, looking forward to the upcoming pip release! 😸

If you want, it should be possible to bump tomli to 1.2.3.

PR #10238 should also unlock 2.0.0 for you.

Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure how I can usefully review this, but it looks OK on a skim, and as long as the CI passes, that works for me.

@pradyunsg pradyunsg merged commit dec279e into pypa:main Jan 27, 2022
@pradyunsg pradyunsg deleted the vendoring-upgrade branch January 27, 2022 07:05
@johnhany97
Copy link

Hey - Is it not possible to not bundle the pre-built .exe files with distlib? I recall this behaviour being previously flagged as a bug in https://bugzilla.redhat.com/show_bug.cgi?id=2006788 and was wondering why we re-introduced them.

@pfmoore
Copy link
Member

pfmoore commented Feb 7, 2022

@johnhany97 The executables are essential for building script wrappers on Windows, so no, it's not possible to omit them.

We've never omitted them, I don't know if Redhat did something in the past to remove them as part of their pip patching, but that would be down to them, not us.

@johnhany97
Copy link

Got it - Thank you for the speedy reply @pfmoore

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call out modifications to rich and pygments in vendoring policy
4 participants