Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a better error message if a file: URL is not found #10263

Merged
merged 37 commits into from
Oct 8, 2021
Merged

Return a better error message if a file: URL is not found #10263

merged 37 commits into from
Oct 8, 2021
+22 −1

Commits on Oct 2, 2021

  1. Return a better error message if a file is not found 

    Print better error messages if the file/URL is not found.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    752c4f9 View commit details
    Browse the repository at this point in the history

  2. Create 10263.bugfix.rst 

    The news entry for my pull request.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    5afb103 View commit details
    Browse the repository at this point in the history

  3. Format the error message 

    Make it look like the common Python tracebacks.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    6854c25 View commit details
    Browse the repository at this point in the history

  4. Fix an ImportError 

    I forgot to import a standard module before using it.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    d1c19ed View commit details
    Browse the repository at this point in the history

  5. Adjust the error message 

    Set "requests.Request.reason" to get cleaner error messages.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    4473870 View commit details
    Browse the repository at this point in the history

  6. Update the error message 

    Make a simple modification.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    f0086ac View commit details
    Browse the repository at this point in the history

  7. Update the error message 

    Use a prettier string.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    538fb0d View commit details
    Browse the repository at this point in the history

  8. Update the error message 

    Remove a duplicated path.

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
    @DiddiLeija @uranusjr
    DiddiLeija and uranusjr committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    1b674e6 View commit details
    Browse the repository at this point in the history

  9. Create test_bad_url.py 

    A test for this new error message.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    1a0fb42 View commit details
    Browse the repository at this point in the history

  10. Style fixes to test_bad_url.py 

    Fix a SyntaxError, an isort warning, and flake8 style errors.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    8c72c9b View commit details
    Browse the repository at this point in the history

  11. Update test_bad_url.py 

    Make some style fixes.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    99a316b View commit details
    Browse the repository at this point in the history

  12. Update test_bad_url.py 

    Just change the function name.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    1eac21e View commit details
    Browse the repository at this point in the history

  13. Update test_bad_url.py 

    Add a missing parenthesis.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    7141432 View commit details
    Browse the repository at this point in the history

  14. Update test_bad_url.py 

    Fix a SyntaxError.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    2703119 View commit details
    Browse the repository at this point in the history

  15. Update test_bad_url.py 

    Fix another syntax error.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    b6e66ce View commit details
    Browse the repository at this point in the history

  16. Update test_bad_url.py 

    Use the correct way to generate an impossible path.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    fa03122 View commit details
    Browse the repository at this point in the history

  17. Update test_bad_url.py 

    Use f-strings instead of modulo operator.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    b3a62af View commit details
    Browse the repository at this point in the history

  18. Update test_bad_url.py 

    Modify the command passed to the test.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    4f6eb30 View commit details
    Browse the repository at this point in the history

  19. Update test_bad_url.py 

    Fix a syntax error.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    aceefdc View commit details
    Browse the repository at this point in the history

  20. Update test_bad_url.py 

    * Simplify the imaginary pathname.
* Modify the way to test, use a "script.pip" instead of subprocess.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    de0452f View commit details
    Browse the repository at this point in the history

  21. Update test_bad_url.py 

    Add "Any" when importing "typing".
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    029a113 View commit details
    Browse the repository at this point in the history

  22. Update test_bad_url.py 

    Remove a deleted function.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    51274d4 View commit details
    Browse the repository at this point in the history

  23. Update test_bad_url.py 

    Just change a long line.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    12971f4 View commit details
    Browse the repository at this point in the history

  24. Update test_bad_url.py 

    Modify the way to test the requirements file, to avoid an AssertionError.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    b7bce7c View commit details
    Browse the repository at this point in the history

  25. Update test_bad_url.py 

    Squash all the test into a single function.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    9faf241 View commit details
    Browse the repository at this point in the history

  26. Update test_bad_url.py 

    Remove the unused "typing.Tuple".
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    e7ca41e View commit details
    Browse the repository at this point in the history

  27. Update tests/functional/test_bad_url.py 

    Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
    @DiddiLeija @uranusjr
    DiddiLeija and uranusjr committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    5877fbb View commit details
    Browse the repository at this point in the history

  28. Update test_bad_url.py 

    Use a more accurate test.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    5147c2c View commit details
    Browse the repository at this point in the history

  29. Update test_bad_url.py 

    Modify the test catching.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    086b1c0 View commit details
    Browse the repository at this point in the history

  30. Update test_bad_url.py 

    Change the line length.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    2f1227b View commit details
    Browse the repository at this point in the history

  31. Update test_bad_url.py 

    Remove a failing method.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    48884de View commit details
    Browse the repository at this point in the history

  32. Update test_bad_url.py 

    Modify the tests.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    e14674c View commit details
    Browse the repository at this point in the history

  33. Update test_bad_url.py 

    Reduce the string sizes.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    79a6507 View commit details
    Browse the repository at this point in the history

  34. Update test_bad_url.py 

    Add some indentations to the string formatting.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    6f0369c View commit details
    Browse the repository at this point in the history

  35. Update test_bad_url.py 

    Adjust the expected error message.
    @DiddiLeija
    DiddiLeija committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    37242e0 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Update news/10263.bugfix.rst

    @pradyunsg
    pradyunsg authored Oct 8, 2021
    Configuration menu
    Copy the full SHA
    dee894b View commit details
    Browse the repository at this point in the history

  2. Update news/10263.bugfix.rst

    @pradyunsg
    pradyunsg authored Oct 8, 2021
    Configuration menu
    Copy the full SHA
    dd1103f View commit details
    Browse the repository at this point in the history