Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the phrasing of in-tree build deprecation warning #10129

Merged
merged 4 commits into from
Jul 30, 2021
Merged

Improve the phrasing of in-tree build deprecation warning #10129

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1418b5f
Improve the phrasing of in-tree-build deprecation
maresb Jul 7, 2021
a2252a3
Switch deprecation message to use feature_flag
maresb Jul 27, 2021
89f6c91
Improve style for multiline string
maresb Jul 29, 2021
e8b5b58
Fix long line
maresb Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/10128.removal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve deprecation warning regarding the copying of source trees when installing from a local directory.
11 changes: 5 additions & 6 deletions src/pip/_internal/operations/prepare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,14 +216,13 @@ def unpack_url(
# be removed.
if link.is_existing_dir():
deprecated(
"A future pip version will change local packages to be built "
"in-place without first copying to a temporary directory. "
"We recommend you use --use-feature=in-tree-build to test "
"your packages with this new behavior before it becomes the "
"default.\n",
reason="pip copied the source tree into a temporary directory "
"before building it. This is changing so that packages are built in-place "
'within the original source tree ("in-tree build").',
maresb marked this conversation as resolved.
Show resolved Hide resolved
replacement=None,
gone_in="21.3",
issue=7555
feature_flag="in-tree-build",
issue=7555,
)
if os.path.isdir(location):
rmtree(location)
Expand Down