Add topic guide: Dependency Resolution #10102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
type: docs
uranusjr
reviewed
Jul 1, 2021
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
This reads clearer than the initial iteration. Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> Co-authored-by: Paul Moore <p.f.moore@gmail.com>
|
Uhhh... I should set up GPG signing on this laptop. |
uranusjr
reviewed
Jul 11, 2021
Comment on lines
14
to
17
| pip does not have all the information it needs to work out the dependencies of | ||
| the requested packages. Over the course of the dependency resolution process, | ||
| pip needs to download distributions of the package, which can then provide | ||
| the list of dependencies that the package requires. |
There was a problem hiding this comment.
The first sentence is confusing for a pip user IMO. pip cannot work out dependencies? WTF?
There was a problem hiding this comment.
Nice catch. This needs something like "when it begins".
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
- Clarify that pip is incrementally building up this information. - Clarify that pip has to download files, which contain the dependency information. - Hint at the fact that this is a recursive process.
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
|
Good bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one needs a proper review, since I can't figure out how to best explain things here; and what stuff to move into this.
The basic idea was to move https://pip.pypa.io/en/stable/user_guide/#dependency-resolution-backtracking into this document, which would go a long way toward making the user guide shorter.
Toward #9475.