Add topic guide: Repeatable Installs #10100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
type: docs
uranusjr
reviewed
Jul 1, 2021
Comment on lines
+93
to
+98
| ```{warning} | ||
| Beware of the `setup_requires` keyword arg in {file}`setup.py`. The (rare) | ||
| packages that use it will cause those dependencies to be downloaded by | ||
| setuptools directly, skipping pip's protections. If you need to use such a | ||
| package, see {ref}`Controlling setup_requires <controlling-setup-requires>`. | ||
| ``` |
There was a problem hiding this comment.
This reads a bit confusing to me at first since a wheelhouse contains only wheels and setup_requires shouldn’t affect it? Then I realise this is probably talking about the population phase (i.e. pip wheel can use hash-checking mode, but that does not protect you from requirements listed in setup_requires). Maybe this could be restructured to make it clearer.
Also, should this also be mentioned in the hash-checking section above?
There was a problem hiding this comment.
Hmm... I think I just borrowed this verbatim from the original text we had already.
There was a problem hiding this comment.
Made https://github.com/pypa/pip/projects/8#card-64934958 to follow up on this!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #9475