Add topic guide: VCS Support #10099
Merged
Add topic guide: VCS Support #10099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
skip news
uranusjr
reviewed
Jul 1, 2021
Comment on lines
+25
to
+29
| ```{warning} | ||
| The use of `git`, `git+git`, and `git+http` schemes is discouraged. | ||
| The former two use [the Git Protocol], which lacks authentication, and HTTP is | ||
| insecure due to lack of TLS based encryption. | ||
| ``` |
There was a problem hiding this comment.
I wonder if we should just mention git+file, git+https, and git+ssh in the opening paragraph, and add a “oh btw we also recognise these other three but they are bad anyway” note here.
There was a problem hiding this comment.
Maybe. Let's defer this for a follow up PR though, since one of the things I like about the way it's currently written is that all the sections have the exact same start that lists all the things.
uranusjr
approved these changes
Jul 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #9475.