Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the Getting Started and Installation Pages #10009

Merged
merged 10 commits into from
May 23, 2021

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented May 21, 2021

Toward #9475
Borrows from and closes #9137

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label May 21, 2021
@pradyunsg
Copy link
Member Author

pradyunsg commented May 21, 2021

Oops! Need to setup GPG keys on the not-owned-by-me-but-in-my-possesion laptop!

@pradyunsg pradyunsg force-pushed the new-getting-started-and-installation branch from 13ff11a to c5e9314 Compare May 21, 2021 23:29
@pradyunsg pradyunsg force-pushed the new-getting-started-and-installation branch from c5e9314 to 6af200a Compare May 21, 2021 23:31
@pradyunsg pradyunsg force-pushed the new-getting-started-and-installation branch from 6af200a to 1b38636 Compare May 21, 2021 23:33
@pradyunsg
Copy link
Member Author

Merging! If there's any concerns, just flag them in #9475 and I'll address them in a follow up. :)

@pradyunsg pradyunsg merged commit 0a49dd9 into pypa:main May 23, 2021
@pradyunsg pradyunsg deleted the new-getting-started-and-installation branch May 23, 2021 10:54
More details about how {mod}`ensurepip` works and how it can be used, is
available in the standard library documentation.

### `get-pip.py`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... I think this refactoring removed a lot of labels: https://webknjaz.github.io/intersphinx-untangled/pip.pypa.io/

Copy link
Member

@webknjaz webknjaz May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's time to enable autolabel.

Copy link
Member Author

@pradyunsg pradyunsg May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradyunsg looks like this title has lost its label causing https://github.com/pypa/packaging.python.org/pull/898/checks?check_run_id=2655734156#step:6:34

Ah, nice catch.

We should probably update that to point to https://github.com/pypa/get-pip/#readme instead, since that's the source of truth for information about get-pip now.

I wonder if it's time to enable autolabel.

I don't want every heading to be an "intersphinx contract" that this documentation needs to be mindful of when making changes.

Hm... I think this refactoring removed a lot of labels:

That's correct. Is that a problem somehow?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. Is that a problem somehow?

My understanding is that they used to be exposed via intersphinx and now they are not. So this has probably broken some sphinx sites.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want every heading to be an "intersphinx contract" that this documentation needs to be mindful of when making changes.

I agree with this. I don't think that our previous documentation was well-enough structured that we want to be blocked from improving it just because some sites linked to individual sections. (I don't think that docs are ever so perfect that not being able to reorganise them is reasonable, actually...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this. I don't think that our previous documentation was well-enough structured that we want to be blocked from improving it just because some sites linked to individual sections. (I don't think that docs are ever so perfect that not being able to reorganise them is reasonable, actually...)

I believe that Pradyun's comment was not about the old titles but about enabling automatic label creation based on title names. Sphinx has a built-in extension called autolabel for this. With this, there wouldn't be any need to create manual labels before titles.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants