-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support writing metadata #846
base: main
Are you sure you want to change the base?
Conversation
I don't know if I'm comfortable with the JSON support. I actually almost had it in the first version of the module, but decided against it until we had a standard around it. |
Well, it is in PEP 566, so that's why I added it to pyproject-metadata. Though there's no use for it yet, so I can easily drop it. I'll probably make a PR building on this PR for the next step. This is starting as a fairly direct copy of pyproject-metadata, adapted for packaging's existing features and with the non-backward compatible changes listed in pypa/pyproject-metadata#140. I've got permission from the original copyright holders in pypa/pyproject-metadata#103 to contribute to packaging under the packaging license. This PR also has the following changes vs. the original:
|
1774407
to
ebfed9f
Compare
FYI, on the flaking pypy-3.8 (and 3.9, possibly?) test, PyPy doesn't support pypy-3.8 or pypy-3.9 anymore. Only pypy-3.10 is actively supported. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
56a9c70
to
68ff492
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
68ff492
to
bc2ab34
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Working toward #647. Starting by making it possible to go from Metadata back to RFC822.