Fix uninformative error message #830
Merged
+9
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that there was an easy oversight when implementing the error message for invalid dynamic fields.
Right now, it shows the name of all fields that are listed (including the valid ones), instead of showing only the name of the invalid field.
For example, exception looks like the following:
... which is not very great, because it lets to the user the work of figuring out which one of these fields is invalid..
A better error message (which I believe to be the original intent) would be: