Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add Python 3.11, update checkout to v3, weekly run #551

Closed
wants to merge 2 commits into from

Conversation

EwoutH
Copy link

@EwoutH EwoutH commented May 24, 2022

A bit of maintenance on the CI:

  • Add Python 3.11 (which is currently in beta) to the build matrix of the CI test job
  • A weekly scheduled run is also added to catch changes in dependencies and environments (each Monday at 06:00 UTC), and workflow_dispatch is added to be able to manually trigger the CI workflow
  • The checkout actions is updated to v3

- Add Python 3.11 (which is currently in beta) to the build matrix of the CI test job
- A weekly scheduled run is also added to catch changes in dependencies and environments (each Monday at 06:00 UTC), and workflow_dispatch is added to be able to manually trigger the CI workflow
- The checkout actions is updated to v3
@EwoutH
Copy link
Author

EwoutH commented May 30, 2022

Hi @brettcannon and @mayeut, would one of you be able to enable the workflow and take a look at this PR?

@brettcannon brettcannon self-requested a review June 2, 2022 21:22
@brettcannon
Copy link
Member

Unfortunately CI is failing based on how we create the version string to pass into nox.

Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid you will need to manipulate the 3.11-dev string to be just 3.11 to pass into nox.

@brettcannon
Copy link
Member

@EwoutH did you want to try and make this work? Or should I just go ahead and close the PR?

@henryiii
Copy link
Contributor

henryiii commented Aug 25, 2022

Can't you just add a line like:

INTERPRETER=${INTERPRETER/-dev/}

Right before the similar line that just strips -?

@henryiii
Copy link
Contributor

This should also add the 3.11 trove classier, though that will clash with the moves in #546.

@mayeut mayeut mentioned this pull request Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants