-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adhere to PEP 685 when evaluating markers with extras #545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just want to simplify the code a bit.
FYI I have an in-progress PR that also normalizes the value so that the string representation is fully normalized. But I like the solution for this part of it by @hroncok more than mine. 🙂 |
There is a fixup commit now. Please squash when (or before) merging or tell me to do it when ready. |
Please go ahead and squash. I learnt this recently: If you make a force-push with a single commit amended, it's possible to see what you've changed in the force-push -- by clicking "force-pushed" text in the event that GitHub adds. This is useful for exactly the situation we have here -- a single commit fixup. :) |
The change LGTM, so like Pradyun said, please go ahead and squash. 🙂 |
Done. |
PEP: https://peps.python.org/pep-0685/
Original problem: https://discuss.python.org/t/7614
Part of #526