Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PoC] Add Core Metadata API (as a dataclass) #498

Closed
wants to merge 26 commits into from
Closed

[PoC] Add Core Metadata API (as a dataclass) #498

wants to merge 26 commits into from

Commits on Jan 21, 2022

  1. Add implementation of core metadata as a dataclass

    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    991f08f View commit details
    Browse the repository at this point in the history

  2. Make Requirement hashable

    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    db51418 View commit details
    Browse the repository at this point in the history

  3. Add tests for core metadata

    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    b421d1d View commit details
    Browse the repository at this point in the history

  4. Remove positonal only arguments 

    (Not supported in old versions of Python)
    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    598288a View commit details
    Browse the repository at this point in the history

  5. Remove custom mapping class in metadata

    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    e8b51d2 View commit details
    Browse the repository at this point in the history

  6. Remove micro-optmisation (cache) from metadata

    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    800844c View commit details
    Browse the repository at this point in the history

  7. Use flags in examples for metadata tests 

    As mentioned in the review for pypa#498, conditions in tests should not be
based in what the code being tested, otherwise they might end up hiding
other problems.

The solution is to pass flags in the test parameters themselves.
    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    3aaa73e View commit details
    Browse the repository at this point in the history

  8. Improve grammar for comment in metadata 

    Co-authored-by: Brett Cannon <brett@python.org>
    @abravalheri @brettcannon
    abravalheri and brettcannon committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    50c13b7 View commit details
    Browse the repository at this point in the history

  9. Improve condition in metadata 

    Co-authored-by: Brett Cannon <brett@python.org>
    @abravalheri @brettcannon
    abravalheri and brettcannon committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    147592b View commit details
    Browse the repository at this point in the history

  10. Remove unused instructions in metadata

    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    3c89525 View commit details
    Browse the repository at this point in the history

  11. Preserve order fields are defined in metadata

    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    0b7442c View commit details
    Browse the repository at this point in the history

  12. Make email headers don't leak into the metadata

    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    7dce2a3 View commit details
    Browse the repository at this point in the history

  13. Ensure serialized metadata is not empty

    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    10439f0 View commit details
    Browse the repository at this point in the history

  14. Rename _read_pkg_info to _parse_pkg_info

    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    dd57033 View commit details
    Browse the repository at this point in the history

  15. Use a plain tuple to represent emails in metadata

    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    991d65f View commit details
    Browse the repository at this point in the history

  16. Revert "Make Requirement hashable" 

    This reverts commit 215c172.
    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    dda204b View commit details
    Browse the repository at this point in the history

  17. Change metadata tests to not rely on __hash__/__eq__

    @abravalheri
    abravalheri committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    f1625d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. Use inspect.clean doc to unescape description in core metadata

    @abravalheri
    abravalheri committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    95638b3 View commit details
    Browse the repository at this point in the history

  2. Remove __post_init__

    @abravalheri
    abravalheri committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    31f1d22 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. Extract url parsing in its own method

    @abravalheri
    abravalheri committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    adb8ec1 View commit details
    Browse the repository at this point in the history

  2. Fix dynamic validation

    @abravalheri
    abravalheri committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    dd6db44 View commit details
    Browse the repository at this point in the history

  3. Separate required fields validation

    @abravalheri
    abravalheri committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    f020115 View commit details
    Browse the repository at this point in the history

  4. Remove unused _setattr

    @abravalheri
    abravalheri committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    bac39bc View commit details
    Browse the repository at this point in the history

  5. Remove 'frozen' behaviour from metadata

    @abravalheri
    abravalheri committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    1ed4123 View commit details
    Browse the repository at this point in the history

  6. Unify {to/from}_pkg_info with {to/from}_dist_info_metadata 

    As discussed in pypa#383 instead of having 2 separated sets of methods
(one for `PKG-INFO` files in sdists and one for `METADATA` files in wheels)
we can have a single pair to/from functions with an
`allow_unfilled_dynamic` keyword argument.
    @abravalheri
    abravalheri committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    1ca3573 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Use type_extensions in TYPE_CHECKING guard 

    As indicated in the [code review](pypa#498 (comment))
type checkers consider `typing_extensions` as part of the stdlib, so it
does not need to be explicitly installed.
    @abravalheri
    abravalheri committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    73eef47 View commit details
    Browse the repository at this point in the history