Replace regex which allows dubble hyphens by one that does not. #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version disallows tripple hyphens but allows dubble hyphens. (It also seems overcomplicated) Alternatively we can make it a negative lookbehind instead of a negative lookahead, but the complexity is much higher. See https://regex101.com/r/Xyu0bt/1 for proof the current version matches double hyphens
|
LGTM. @brettcannon you made the last change to this regex in #1076. Do you agree with this? |
jeanas
approved these changes
Jan 26, 2024
brettcannon
approved these changes
Jan 26, 2024
|
Yep, the change seems to work! |
chrysle
approved these changes
Jan 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version disallows tripple hyphens but allows dubble hyphens. (It also seems overcomplicated)
Alternatively we can make it a negative lookbehind instead of a negative lookahead, but the complexity is much higher.
See https://regex101.com/r/Xyu0bt/1 for proof the current version matches double hyphens
📚 Documentation preview 📚: https://python-packaging-user-guide--1491.org.readthedocs.build/en/1491/