-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Creating Documentation tutorial #1345
Conversation
Perhaps we can make the page a redirect to, e.g., https://www.sphinx-doc.org/en/master/tutorial/index.html, to avoid breaking links? Patch: diff --git a/requirements.txt b/requirements.txt
index d6e0d75..42fb1a1 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -5,3 +5,4 @@ python-docs-theme==2023.9
sphinx-copybutton==0.5.0
pypa-docs-theme @ git+https://github.com/pypa/pypa-docs-theme.git
sphinx-toolbox==3.5.0
+sphinx-reredirects==0.1.3
diff --git a/source/conf.py b/source/conf.py
index 9113b8c..e083e7c 100644
--- a/source/conf.py
+++ b/source/conf.py
@@ -36,6 +36,7 @@ extensions = [
'sphinx.ext.todo',
'sphinx_inline_tabs',
'sphinx_copybutton',
+ 'sphinx_reredirects',
'sphinx_toolbox.collapse',
]
@@ -446,3 +447,8 @@ nitpick_ignore = [
('py:func', 'setuptools.find_packages'),
('py:func', 'setuptools.setup'),
]
+
+# Redirects for deleted/moved pages
+redirects = {
+ "tutorials/creating-documentation": "https://www.sphinx-doc.org/en/master/tutorial",
+} |
I do agree that we should drop this page, and I also share the concern of dropping the page without redirects breaking existing links. However, I don't like the idea of silently redirecting to another domain though -- it's a hard-coded link in source code that can't be checked for whether it is out of date automatically via Sphinx's linkcheck. @willingc How do you feel about keeping the toctree removal and replacing page with a orphan stub page? Something like the following (wrapping where appropriate)...
|
Great suggestion about the breaking links. I like the @pradyunsg's suggestion for a stub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better now.
Hah, nice @jeanas! ^.^ |
This tutorial is dated. It's also not directly related to packaging. It would be better to create a new docs tutorial or refer to existing documentation in other places.
I could see a future "How to" guide about making documentation be an extra installation.