Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial draft of src vs flat layout discussion #1150

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Sep 30, 2022

x-ref #320

This discussion covers the main topics discussed in #320, trimming the opinions/preferences stated there and keeping things limited to the behaviour differences between the two formats. I've followed the same style as pip vs easy_install or wheel vs egg pages here.

@pradyunsg
Copy link
Member Author

pradyunsg commented Sep 30, 2022

This still needs a bunch of cross references to be added, and a round of copy-editing.

This serves to document the behaviour differences between the src layout
and the flat layout, and how they might matter to users.
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like the right sort of level to me - discuss the trade-offs but keep it simple.

I'm assuming that this section is not where we offer a recommendation. The fact that https://packaging.python.org/en/latest/tutorials/packaging-projects/ uses the src layout is where our recommendation is stated (implicitly).

@pradyunsg
Copy link
Member Author

pradyunsg commented Sep 30, 2022

I'm assuming that this section is not where we offer a recommendation.

FWIW, I'm personally not going to get into the recommendations rabbit hole for this right now. That'll be someone else's problem or future me's problem, when I come around to this site after https://github.com/pradyunsg/lutra/ is good to go.

@pradyunsg pradyunsg force-pushed the add-src-non-src-discussion branch from cfad34a to 3c0750f Compare September 30, 2022 18:03
This rewords certain bits and fixes typos.
@pradyunsg pradyunsg marked this pull request as ready for review September 30, 2022 18:18
@pradyunsg
Copy link
Member Author

This is good to go from my end. If I could get a couple of approvals on this, I’m happy to land this myself.

I am also more than happy to trust the judgement of currently-active maintainers on the guide, if they want to land this sooner. :)

Copy link
Member

@takluyver takluyver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

As I recall, a big part of the discussion around this related to test files, where people like to put them, whether they get installed as part of the package or not, and whether you ever want to test the source package as opposed to the installed package. I don't think you need to tackle that topic in this PR, but I imagine it might get added at some point. 🙂

@pradyunsg pradyunsg merged commit 537d055 into pypa:main Oct 3, 2022
@pradyunsg pradyunsg deleted the add-src-non-src-discussion branch October 3, 2022 19:44
@pradyunsg
Copy link
Member Author

As I recall, a big part of the discussion around this related to test files

It certainly was! I wanted to start with the unambigous bits and I'm gonna be cautious and not take implicit dibs on the task of expanding this to cover test layouts. It might be an idea to have that discussion in a separate file even.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants