Validate RECORD file using streams instead of reading in-memory #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the validation can be performed without loading a file in-memory.
This ensures that the hashing logic within the codebase does not attempt to read large files into memory, which can cause OOM issues.
pradyunsg
added
type: bug
This function is no longer meant to be used, since there's a superior alternative available.
pradyunsg
force-pushed
the
validate-stream
branch
from
b43ed95
to
b52f72f
Compare
|
Thank you @pradyunsg , your solution is cleaner :) Another optimization that we can bring is performing hash validation just once, as we currently perform it during 1. wheel validation 2. wheel installation. I tried hacking it away in python-poetry/poetry#8027 but it would be clearly better to see this natively supported by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes and closes #183
Fixes #185
This ensures that the validation can be performed without loading the entire file in-memory.