Remove redundant Path.absolute() call
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpollock
referenced
this pull request
in google/osv.dev
Sep 25, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github/codeql-action](https://redirect.github.com/github/codeql-action) | action | patch | `v2.26.7` -> `v2.26.9` | | [github/codeql-action](https://redirect.github.com/github/codeql-action) | action | patch | `v3.26.7` -> `v3.26.9` | | [pypa/gh-action-pypi-publish](https://redirect.github.com/pypa/gh-action-pypi-publish) | action | patch | `v1.10.1` -> `v1.10.2` | --- ### Release Notes <details> <summary>github/codeql-action (github/codeql-action)</summary> ### [`v2.26.9`](https://redirect.github.com/github/codeql-action/compare/v2.26.8...v2.26.9) [Compare Source](https://redirect.github.com/github/codeql-action/compare/v2.26.8...v2.26.9) ### [`v2.26.8`](https://redirect.github.com/github/codeql-action/compare/v2.26.7...v2.26.8) [Compare Source](https://redirect.github.com/github/codeql-action/compare/v2.26.7...v2.26.8) </details> <details> <summary>pypa/gh-action-pypi-publish (pypa/gh-action-pypi-publish)</summary> ### [`v1.10.2`](https://redirect.github.com/pypa/gh-action-pypi-publish/releases/tag/v1.10.2) [Compare Source](https://redirect.github.com/pypa/gh-action-pypi-publish/compare/v1.10.1...v1.10.2) #### 💅 Cosmetic Output Improvements In [#​250](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/250) and [#​258](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/258), [@​facutuesca](https://redirect.github.com/facutuesca)[💰](https://redirect.github.com/sponsors/facutuesca) added a nudge message with a magic link to pre-fill the creation of new Trusted Publishers configurations on PyPI. The users are now suggested to configure tokenless publishing by clicking a link printed in the job summary when it's detected that they publish to PyPI or TestPyPI. Just like magic! 🦄 #### 🛠️ Internal Dependencies [@​woodruffw](https://redirect.github.com/woodruffw)[💰](https://redirect.github.com/sponsors/woodruffw) bumped `pypi-attestations` to v0.0.12 in [#​262](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/262), ~hopefully fixing [#​263](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/263). 🤞~ Nah.. that wasn't it. > \[!TIP] > Please keep in mind that reusable workflows are not yet supported, even though they sometimes work, mostly by accident. #### 💪 New Contributors [@​facutuesca](https://redirect.github.com/facutuesca) made their first contribution in [https://github.com/pypa/gh-action-pypi-publish/pull/258](https://redirect.github.com/pypa/gh-action-pypi-publish/pull/258) **🪞 Full Diff**: pypa/gh-action-pypi-publish@v1.10.1...v1.10.2 **🧔♂️ Release Manager:** [@​webknjaz 🇺🇦](https://redirect.github.com/sponsors/webknjaz) **🙏 Special Thanks** to [@​henryiii](https://redirect.github.com/henryiii)[💰](https://redirect.github.com/sponsors/henryiii) for promptly pointing up possible fixes for [#​263](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/263). </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on wednesday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/google/osv.dev). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->
github-merge-queue bot
referenced
this pull request
in openapi-generators/openapi-python-client
Sep 26, 2024
) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pypa/gh-action-pypi-publish](https://redirect.github.com/pypa/gh-action-pypi-publish) | action | patch | `v1.10.1` -> `v1.10.2` | --- ### Release Notes <details> <summary>pypa/gh-action-pypi-publish (pypa/gh-action-pypi-publish)</summary> ### [`v1.10.2`](https://redirect.github.com/pypa/gh-action-pypi-publish/releases/tag/v1.10.2) [Compare Source](https://redirect.github.com/pypa/gh-action-pypi-publish/compare/v1.10.1...v1.10.2) #### 💅 Cosmetic Output Improvements In [#​250](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/250) and [#​258](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/258), [@​facutuesca](https://redirect.github.com/facutuesca)[💰](https://redirect.github.com/sponsors/facutuesca) added a nudge message with a magic link to pre-fill the creation of new Trusted Publishers configurations on PyPI. The users are now suggested to configure tokenless publishing by clicking a link printed in the job summary when it's detected that they publish to PyPI or TestPyPI. Just like magic! 🦄 #### 🛠️ Internal Dependencies [@​woodruffw](https://redirect.github.com/woodruffw)[💰](https://redirect.github.com/sponsors/woodruffw) bumped `pypi-attestations` to v0.0.12 in [#​262](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/262), hopefully fixing [#​263](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/263). 🤞 #### 💪 New Contributors [@​facutuesca](https://redirect.github.com/facutuesca) made their first contribution in [https://github.com/pypa/gh-action-pypi-publish/pull/258](https://redirect.github.com/pypa/gh-action-pypi-publish/pull/258) **🪞 Full Diff**: pypa/gh-action-pypi-publish@v1.10.1...v1.10.2 **🧔♂️ Release Manager:** [@​webknjaz 🇺🇦](https://redirect.github.com/sponsors/webknjaz) **🙏 Special Thanks** to [@​henryiii](https://redirect.github.com/henryiii)[💰](https://redirect.github.com/sponsors/henryiii) for promptly pointing up possible fixes for [#​263](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/263). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/openapi-generators/openapi-python-client). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in this open PR: #250 (review),
Path.resolve().absolute()is redundant. This removes an occurrence of it in the codebase.