twine-upload: fix tense on password nudge #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes password use a hard error on PyPI. Signed-off-by: William Woodruff <william@trailofbits.com>
|
Interesting CI failure: Traceback (most recent call last):
File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/bin/flake8", line 8, in <module>
sys.exit(main())
^^^^^^
File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/cli.py", line 22, in main
app.run(argv)
File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 375, in run
self._run(argv)
File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 363, in _run
self.initialize(argv)
File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 343, in initialize
self.find_plugins(config_finder)
File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 157, in find_plugins
self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 363, in __init__
self.manager = PluginManager(
^^^^^^^^^^^^^^
File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 243, in __init__
self._load_entrypoint_plugins()
File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 261, in _load_entrypoint_plugins
eps = importlib_metadata.entry_points().get(self.namespace, ())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'EntryPoints' object has no attribute 'get' |
|
@woodruffw that's because of the Python 3.11->3.12 bump in pre-commit.ci. I'll fix that separately, it's already on my radar. |
webknjaz
reviewed
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes the password case a hard error on
pypi.org, since we know it's going to fail. But I'm happy to revert that if you'd prefer to display the error and lettwine uploadfail instead 🙂Fixes #233