Unrequire the password input in action metadata
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… trusted publishing Signed-off-by: Asher Foa <1268088+asherf@users.noreply.github.com>
|
Oh, interesting... How did you catch that? Did GH complain? I suppose it's not broken in the runtime but emits annoying warnings somewhere, right? |
VS code, when editing the workflow file. see screenshot:
(it is not actually preventing things from working properly).... |
|
Ah, cool. That's happening on the jsonschema level... So integrating https://check-jsonschema.readthedocs.io/en/latest/precommit_usage.html#check-github-actions would help. |
webknjaz
changed the title
password input in action metadata
|
@asherf do you know which schema does your VS Code extension use? Or at least, which extension reports that? |
|
I think this extension is the one reporting it: https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions |
|
Ah, cool, thanks! I think I won't be adding any linting to this PR after all. It's harder to implement than I thought originally. At least, in a way that would catch bugs like this… Maybe, some other time. |
|
I've just tagged this as v1.8.6 🎉 |
renovate bot
referenced
this pull request
in allenporter/flux-local
May 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pypa/gh-action-pypi-publish](https://togithub.com/pypa/gh-action-pypi-publish) | action | patch | `v1.8.5` -> `v1.8.6` | --- ### Release Notes <details> <summary>pypa/gh-action-pypi-publish</summary> ### [`v1.8.6`](https://togithub.com/pypa/gh-action-pypi-publish/releases/tag/v1.8.6) [Compare Source](https://togithub.com/pypa/gh-action-pypi-publish/compare/v1.8.5...v1.8.6) #### What's Updated - [@​woodruffw] dropped the references to a “private beta” from the project docs and runtime in [https://github.com/pypa/gh-action-pypi-publish/pull/147](https://togithub.com/pypa/gh-action-pypi-publish/pull/147). He also clarified that the API tokens are still more secure than passwords in [https://github.com/pypa/gh-action-pypi-publish/pull/150](https://togithub.com/pypa/gh-action-pypi-publish/pull/150). - [@​asherf] noticed that the action metadata incorrectly marked the `password` field as required and contributed a correction in [https://github.com/pypa/gh-action-pypi-publish/pull/151](https://togithub.com/pypa/gh-action-pypi-publish/pull/151) - [@​webknjaz] moved the Trusted Publishing example to the top of the README in hopes that new users would default to using it via pypa/gh-action-pypi-publish@f47b347 #### New Contributors - [@​asherf] made their first contribution in [https://github.com/pypa/gh-action-pypi-publish/pull/151](https://togithub.com/pypa/gh-action-pypi-publish/pull/151) **Full Diff**: pypa/gh-action-pypi-publish@v1.8.5...v1.8.6 [@​asherf]: https://togithub.com/sponsors/asherf [@​webknjaz]: https://togithub.com/sponsors/webknjaz [@​woodruffw]: https://togithub.com/sponsors/woodruffw </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43MS4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in allenporter/pyrainbird
May 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pypa/gh-action-pypi-publish](https://togithub.com/pypa/gh-action-pypi-publish) | action | patch | `v1.8.5` -> `v1.8.6` | --- ### Release Notes <details> <summary>pypa/gh-action-pypi-publish</summary> ### [`v1.8.6`](https://togithub.com/pypa/gh-action-pypi-publish/releases/tag/v1.8.6) [Compare Source](https://togithub.com/pypa/gh-action-pypi-publish/compare/v1.8.5...v1.8.6) #### What's Updated - [@​woodruffw] dropped the references to a “private beta” from the project docs and runtime in [https://github.com/pypa/gh-action-pypi-publish/pull/147](https://togithub.com/pypa/gh-action-pypi-publish/pull/147). He also clarified that the API tokens are still more secure than passwords in [https://github.com/pypa/gh-action-pypi-publish/pull/150](https://togithub.com/pypa/gh-action-pypi-publish/pull/150). - [@​asherf] noticed that the action metadata incorrectly marked the `password` field as required and contributed a correction in [https://github.com/pypa/gh-action-pypi-publish/pull/151](https://togithub.com/pypa/gh-action-pypi-publish/pull/151) - [@​webknjaz] moved the Trusted Publishing example to the top of the README in hopes that new users would default to using it via pypa/gh-action-pypi-publish@f47b347 #### New Contributors - [@​asherf] made their first contribution in [https://github.com/pypa/gh-action-pypi-publish/pull/151](https://togithub.com/pypa/gh-action-pypi-publish/pull/151) **Full Diff**: pypa/gh-action-pypi-publish@v1.8.5...v1.8.6 [@​asherf]: https://togithub.com/sponsors/asherf [@​webknjaz]: https://togithub.com/sponsors/webknjaz [@​woodruffw]: https://togithub.com/sponsors/woodruffw </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43MS4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
michaelkedar
referenced
this pull request
in google/osv.dev
May 26, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github/codeql-action](https://togithub.com/github/codeql-action) | action | patch | `v2.3.3` -> `v2.3.5` | | [pypa/gh-action-pypi-publish](https://togithub.com/pypa/gh-action-pypi-publish) | action | patch | `v1.8.5` -> `v1.8.6` | --- ### Release Notes <details> <summary>github/codeql-action</summary> ### [`v2.3.5`](https://togithub.com/github/codeql-action/compare/v2.3.4...v2.3.5) [Compare Source](https://togithub.com/github/codeql-action/compare/v2.3.4...v2.3.5) ### [`v2.3.4`](https://togithub.com/github/codeql-action/compare/v2.3.3...v2.3.4) [Compare Source](https://togithub.com/github/codeql-action/compare/v2.3.3...v2.3.4) </details> <details> <summary>pypa/gh-action-pypi-publish</summary> ### [`v1.8.6`](https://togithub.com/pypa/gh-action-pypi-publish/releases/tag/v1.8.6) [Compare Source](https://togithub.com/pypa/gh-action-pypi-publish/compare/v1.8.5...v1.8.6) #### What's Updated - [@​woodruffw] dropped the references to a “private beta” from the project docs and runtime in [https://github.com/pypa/gh-action-pypi-publish/pull/147](https://togithub.com/pypa/gh-action-pypi-publish/pull/147). He also clarified that the API tokens are still more secure than passwords in [https://github.com/pypa/gh-action-pypi-publish/pull/150](https://togithub.com/pypa/gh-action-pypi-publish/pull/150). - [@​asherf] noticed that the action metadata incorrectly marked the `password` field as required and contributed a correction in [https://github.com/pypa/gh-action-pypi-publish/pull/151](https://togithub.com/pypa/gh-action-pypi-publish/pull/151) - [@​webknjaz] moved the Trusted Publishing example to the top of the README in hopes that new users would default to using it via pypa/gh-action-pypi-publish@f47b347 #### New Contributors - [@​asherf] made their first contribution in [https://github.com/pypa/gh-action-pypi-publish/pull/151](https://togithub.com/pypa/gh-action-pypi-publish/pull/151) **Full Diff**: pypa/gh-action-pypi-publish@v1.8.5...v1.8.6 [@​asherf]: https://togithub.com/sponsors/asherf [@​webknjaz]: https://togithub.com/sponsors/webknjaz [@​woodruffw]: https://togithub.com/sponsors/woodruffw </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on wednesday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/google/osv.dev). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40OC4yIiwidXBkYXRlZEluVmVyIjoiMzUuOTguMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #123, with Trusted Publishing being implemented, the missing or empty password started being used as a feature flag implying OIDC flow.
Ref: 2b46bad8